morningman commented on PR #406: URL: https://github.com/apache/doris-thirdparty/pull/406#issuecomment-5250464425
Superseded by apache/doris#66650, which fixes this at the source instead. The reason `md5sum` is missing here is that this job runs on macOS, and macOS ships BSD `md5` under a different name. `download-thirdparty.sh` now falls back to it, so the verification this PR was installing `coreutils` to restore happens on its own — and it happens everywhere else too, not only in this job: the macOS build jobs in this repo, `build-thirdparty.yml` and `be-ut-mac.yml` in apache/doris, and anyone building Doris on a Mac, where none of the ~87 archives were being verified at all. Keeping both would mean two repositories fixing the same thing, with the `brew install` here being pure overhead once the script handles `md5`. Closing in favour of the script fix, which also carries a regression test. The analysis of how the 0-byte `src/tsan_interface_atomic.h` came to be published — run 31092954046, job 92588053054 — is kept in the description above and repeated in apache/doris#66650 for whoever needs it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
