Hi Thomas, These changes would require a lot of changes inside ACL library. As I said in cover letter, ACL library was part of IPL code for a while (nearly a year). I don't really want to make significant changes in it just before the release without really good reason - bugs found. Thanks Konstantin
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Friday, June 13, 2014 12:56 PM To: Ananyev, Konstantin Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCHv3 0/5] ACL library Hi Konstantin, > Konstantin Ananyev (5): > Add ACL library (librte_acl) into DPDK > acl: update UT to reflect latest changes in the librte_acl > acl: New test-acl application > acl: New sample l3fwd-acl > acl: add doxygen configuration and start page > > v2 fixes: > * Fixed several checkpatch.pl issues > * Added doxygen related changes > > v3 fixes: > * Fixed even more checkpatch.pl issues Sorry to bother you but after checking v3, I think these errors should be avoided: ERROR: do not use assignment in if condition ERROR: return is not a function, parentheses are not required Thanks -- Thomas
