On Tue, Nov 25, 2014 at 03:28:56PM +0800, Huawei Xie wrote:
> ">> 5" rather than ">> 4"
you need to provide a reference for where this value comes from. Presumably
this is based of the register description in the datasheet for the NIC, so
perhaps
you can add that.
>
> Signed-off-by: Huawei Xie <huawei.xie at intel.com>
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index dacf2db..518597f 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -4172,14 +4172,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi,
> {
> uint32_t vid_idx, vid_bit;
>
> -#define UINT32_BIT_MASK 0x1F
> -#define VALID_VLAN_BIT_MASK 0xFFF
> /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find
> the
> * element first, then find the bits it belongs to
> */
> - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >>
> - sizeof(uint32_t));
> - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK));
> + vid_idx = (uint32_t) ((vlan_id >> 5) & 0x7F);
> + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F));
>
> if (on)
> vsi->vfta[vid_idx] |= vid_bit;
> --
> 1.8.1.4
>
