Hi David,

As suggested, I shall make the modification in the subject in v6.

About performance numbers, I?m working on ENIC PMD documentation (in rst
format), and it will have performance numbers along with some other
relevant details.

Thanks,
-Sujith

From:  David Marchand <david.march...@6wind.com>
Date:  Tuesday, 25 November 2014 3:35 pm
To:  "Sujith Sankar (ssujith)" <ssujith at cisco.com>
Cc:  "dev at dpdk.org" <dev at dpdk.org>, "Prasad Rao (prrao)" <prrao at 
cisco.com>
Subject:  Re: [dpdk-dev] [PATCH v4 0/6] Cisco Systems Inc. VIC Ethernet
PMD - ENIC PMD


Hello Sujith, 

- This is a comment for the whole patchset.
Patch subjects and commitlogs should comply with the "Contribute by
sending patches" section of http://dpdk.org/dev.


I would say, all your patches should be prefixed with "enic: ".

- By the way, can you add some performance numbers as a reference in the
cover letter ?



Thanks.
-- 
David Marchand


On Tue, Nov 25, 2014 at 5:30 PM, Sujith Sankar
<ssujith at cisco.com> wrote:

ENIC PMD is the poll-mode driver for the Cisco Systems Inc. VIC to be
used with DPDK suite.

Sujith Sankar (6):
  ENIC PMD License
  ENIC PMD Makefile
  VNIC common code partially shared with ENIC kernel mode driver
  ENIC PMD specific code
  DPDK-ENIC PMD interface
  DPDK changes for accommodating ENIC PMD

 config/common_linuxapp                     |    5 +
 lib/Makefile                               |    1 +
 lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |    1 +
 lib/librte_pmd_enic/LICENSE                |   27 +
 lib/librte_pmd_enic/Makefile               |   67 ++
 lib/librte_pmd_enic/enic.h                 |  157 ++++
 lib/librte_pmd_enic/enic_clsf.c            |  244 ++++++
 lib/librte_pmd_enic/enic_compat.h          |  142 ++++
 lib/librte_pmd_enic/enic_etherdev.c        |  613 ++++++++++++++
 lib/librte_pmd_enic/enic_main.c            | 1266
++++++++++++++++++++++++++++
 lib/librte_pmd_enic/enic_res.c             |  221 +++++
 lib/librte_pmd_enic/enic_res.h             |  168 ++++
 lib/librte_pmd_enic/vnic/cq_desc.h         |  126 +++
 lib/librte_pmd_enic/vnic/cq_enet_desc.h    |  261 ++++++
 lib/librte_pmd_enic/vnic/rq_enet_desc.h    |   76 ++
 lib/librte_pmd_enic/vnic/vnic_cq.c         |  117 +++
 lib/librte_pmd_enic/vnic/vnic_cq.h         |  152 ++++
 lib/librte_pmd_enic/vnic/vnic_dev.c        | 1063 +++++++++++++++++++++++
 lib/librte_pmd_enic/vnic/vnic_dev.h        |  202 +++++
 lib/librte_pmd_enic/vnic/vnic_devcmd.h     |  774 +++++++++++++++++
 lib/librte_pmd_enic/vnic/vnic_enet.h       |   78 ++
 lib/librte_pmd_enic/vnic/vnic_intr.c       |   83 ++
 lib/librte_pmd_enic/vnic/vnic_intr.h       |  126 +++
 lib/librte_pmd_enic/vnic/vnic_nic.h        |   88 ++
 lib/librte_pmd_enic/vnic/vnic_resource.h   |   97 +++
 lib/librte_pmd_enic/vnic/vnic_rq.c         |  246 ++++++
 lib/librte_pmd_enic/vnic/vnic_rq.h         |  282 +++++++
 lib/librte_pmd_enic/vnic/vnic_rss.c        |   85 ++
 lib/librte_pmd_enic/vnic/vnic_rss.h        |   61 ++
 lib/librte_pmd_enic/vnic/vnic_stats.h      |   86 ++
 lib/librte_pmd_enic/vnic/vnic_wq.c         |  245 ++++++
 lib/librte_pmd_enic/vnic/vnic_wq.h         |  283 +++++++
 lib/librte_pmd_enic/vnic/wq_enet_desc.h    |  114 +++
 mk/rte.app.mk <http://rte.app.mk>                              |    4 +
 34 files changed, 7561 insertions(+)
 create mode 100644 lib/librte_pmd_enic/LICENSE
 create mode 100644 lib/librte_pmd_enic/Makefile
 create mode 100644 lib/librte_pmd_enic/enic.h
 create mode 100644 lib/librte_pmd_enic/enic_clsf.c
 create mode 100644 lib/librte_pmd_enic/enic_compat.h
 create mode 100644 lib/librte_pmd_enic/enic_etherdev.c
 create mode 100644 lib/librte_pmd_enic/enic_main.c
 create mode 100644 lib/librte_pmd_enic/enic_res.c
 create mode 100644 lib/librte_pmd_enic/enic_res.h
 create mode 100644 lib/librte_pmd_enic/vnic/cq_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/cq_enet_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/rq_enet_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_devcmd.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_enet.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_nic.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_resource.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_stats.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.h
 create mode 100644 lib/librte_pmd_enic/vnic/wq_enet_desc.h

--
1.9.1






Reply via email to