Hi Tomas, Yes, you're right, we need to close on this pending item. Thanks for bringing it up.
I am currently working on a patch series, once I send it out I will come back and look into to qos_sched. Is this OK with you? Regards, Cristian -----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, October 16, 2014 5:46 PM To: Dumitrescu, Cristian Cc: dev at dpdk.org; Wu, Jingjing; Liu, Jijiang Subject: Re: [dpdk-dev] [v2 20/23] librte_cfgfile: interpret config files Hi Cristian, 2014-06-04 19:08, Cristian Dumitrescu: > This library provides a tool to interpret config files that have standard > structure. > > It is used by the Packet Framework examples/ip_pipeline sample application. > > It originates from examples/qos_sched sample application and now it makes > this code available as a library for other sample applications to use. > The code duplication with qos_sched sample app to be addressed later. 4 months ago, you said that this duplication will be adressed later. Neither you nor anyone at Intel submitted a patch to clean up that. I just want to be sure that "later" doesn't mean "never" because I'm accepting another "later" word for cleaning old filtering API. Maybe you just forgot it so please prove me that I'm right to accept "later" clean-up, in general. Thanks -- Thomas -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
