Hi Thomas, Given that most of the comments/discussion for this patch set revolved around the removal of COMBINE_LIBS and what libs to build by default, I am inclined to drop this patch set, submit minimal patch to fix compiler errors (initial and main purpose of this patch set) and then submit an RFC regarding the use/removal of COMBINE_LIBS and other outstanding issues in the build system.
Does that sound like a better approach? Thanks, Sergio > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gonzalez Monroy, > Sergio > Sent: Monday, October 13, 2014 5:02 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/6] Update libs build process > > Are there any more comments on this patch set? > > Thanks, > Sergio > > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > > Monroy > > Sent: Thursday, October 9, 2014 2:05 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH v3 0/6] Update libs build process > > > > As per the proposal, this patch set does: > > - Remove CONFIG_RTE_BUILD_COMBINE_LIBS as a configuration option. > > - For static library, build a single/combined library. > > - For shared libraries, build both individual/separated and single/combined > > libraries. > > - Link apps only against single/combined libs. > > - Include external shared libs dependencies when building shared libraries. > > > > v3: > > - Split some of the patches for easier review > > - Improve patches descriptions > > > > Sergio Gonzalez Monroy (6): > > Link combined shared library using CC > > Link apps only against single/combined library > > Remove CONFIG_RTE_BUILD_COMBINE_LIBS and related > > Update library build process > > Avoid duplicated code > > Link apps/DSOs against EXECENV_LDLIBS with --as-needed > > > > config/common_bsdapp | 3 +- > > config/common_linuxapp | 3 +- > > mk/rte.app.mk | 164 > > ++----------------------------------------------- > > mk/rte.lib.mk | 81 ++++++------------------ > > mk/rte.sdkbuild.mk | 2 +- > > mk/rte.sharelib.mk | 54 ++++++++-------- > > mk/rte.vars.mk | 4 -- > > 7 files changed, 54 insertions(+), 257 deletions(-) > > > > -- > > 1.9.3
