Hi Shally,
> -----Original Message-----
> From: Verma, Shally [mailto:[email protected]]
> Sent: Tuesday, May 8, 2018 11:58 AM
> To: Trahe, Fiona <[email protected]>; De Lara Guarch, Pablo
> <[email protected]>
> Cc: Doherty, Declan <[email protected]>; Athreya, Narayana Prasad
> <[email protected]>; Sahu, Sunila
> <[email protected]>; Gupta, Ashish <[email protected]>;
> [email protected]; Sahu, Sunila <[email protected]>; Gupta, Ashish
> <[email protected]>; Kotamarthy, Kanaka
> <[email protected]>; Marisetti, Balaji
> <[email protected]>
> Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>
> Hi Fiona
>
> >-----Original Message-----
> >From: Trahe, Fiona [mailto:[email protected]]
> >Sent: 08 May 2018 16:22
> >To: Verma, Shally <[email protected]>; De Lara Guarch, Pablo
> ><[email protected]>
> >Cc: Doherty, Declan <[email protected]>; Athreya, Narayana
> >Prasad <[email protected]>; Sahu, Sunila
> ><[email protected]>; Gupta, Ashish <[email protected]>;
> >[email protected]; Sahu, Sunila <[email protected]>; Gupta, Ashish
> ><[email protected]>; Trahe, Fiona <[email protected]>
> >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in
> >cryptodev
> >
> >Hi Shally,
> >
> >Reviewing the asymm v2 patch - quick comment:
> >
> >> List of TBDs:
> >> - change PMD ops session_get_size, session_configure, session_clear
> >> to sym_session_* APIs
> >> - change external get_session_private_size to sym_get_session_*
> >> - per-service stats update
> >[Fiona] You'll need to send a deprecation notice for any changes to
> >existing cryptodev APIs in
> >18.05 if you want the changes applied in 18.08
>
> Thanks for info. However, assume API name change is not blocker for spec to be
> in 18.08. So, I planned to do it at later stage after spec get stabilize and
> accepted.
> Do you have any other thoughts to it?
Any modifications to the API, including name changes, require a deprecation
notice.
Making this change will break the compilation of all the apps using it.
What I would suggest is renaming the function and creating a wrapper with the
current name,
calling the new function, and marking it as rte_deprecated.
Something like:
/*
* @deprecated ...
*/
__rte_deprecated
unsigned
rte_cryptodev_get_session_private_size(...) {
return rte_cryptodev_get_sym_session_private_size(...);
}
This way, we can give users time to change to the new API, without breaking
directly the code.
Thanks,
Pablo
>
> Shally
