09/05/2018 14:41, Gaëtan Rivet: > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > > This fix is relying on the RTE_ETH_EVENT_NEW, an API that I think is not > meant to be backported in the stable release that would be targetted by > this commit id.
This event was added in 18.02. So yes it can be backported. > I think this fix is useless without the rest of this series, so I don't > know what is exactly planned about the rest (whether it is backported, > and where), but I would only CC stable if this is planned, and only as > soon as the relevant APIs are introduced. All the series is candidate for 18.02 backport. > > static int > > fs_ethdev_portid_get(const char *name, uint16_t *port_id) > > { > > - uint16_t pid; > > + uint32_t pid; > > I do not see why the port_id is made uint32_t? Is there a reason? Copying Matan's answer: " The maximum port id number can be 0xffff. In this case the loop will be infinite if we use uint16 to iterate over all the ports. "