Thanks Stephen, for pointing this out. I have shared a V2 for the same.
> -----Original Message----- > From: Stephen Hemminger [mailto:[email protected]] > Sent: Friday, May 11, 2018 8:55 PM > To: Varghese, Vipin <[email protected]> > Cc: Yigit, Ferruh <[email protected]>; Wang, Zhihong > <[email protected]>; [email protected] > Subject: Re: [dpdk-dev] [PATCH] net/tap: add default name to tun > > On Fri, 11 May 2018 14:11:59 +0530 > Vipin Varghese <[email protected]> wrote: > > > The change adds default name to reflect TUN PMD instance. if option > > name is not passed, the default dtun is taken. > > > > Signed-off-by: Vipin Varghese <[email protected]> > > --- > > drivers/net/tap/rte_eth_tap.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/tap/rte_eth_tap.c > > b/drivers/net/tap/rte_eth_tap.c index 172a7ba..fa59a76 100644 > > --- a/drivers/net/tap/rte_eth_tap.c > > +++ b/drivers/net/tap/rte_eth_tap.c > > @@ -1665,6 +1665,9 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev) > > params = rte_vdev_device_args(dev); > > memset(remote_iface, 0, RTE_ETH_NAME_MAX_LEN); > > > > + snprintf(tun_name, sizeof(tun_name), "%s%d", > > + DEFAULT_TUN_NAME, tun_unit++); > > Use unsigned to avoid integer wraparound?
