On Thu, May 17, 2018 at 09:26:15AM +0000, Iremonger, Bernard wrote: > Hi Adrien, > > <snip> > > > > > Subject: [PATCH] maintainers: fix responsibility of flow API bits > > > > > > > > The following commits lack MAINTAINERS entries for this mess. > > > > > > > > Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") > > > > Fixes: 19c90af6285c ("app/testpmd: add flow command") > > > > Cc: sta...@dpdk.org > > > > > > > > Signed-off-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> > > > > Cc: Bernard Iremonger <bernard.iremon...@intel.com> > > > > --- > > > > MAINTAINERS | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS index bd08d4292..187817fff > > > > 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -303,6 +303,8 @@ F: devtools/test-null.sh Flow API > > > > M: Adrien Mazarguil <adrien.mazarg...@6wind.com> > > > > T: git://dpdk.org/next/dpdk-next-net > > > > +F: app/test-pmd/cmdline_flow.c > > > > +F: doc/guides/prog_guide/rte_flow.rst > > > > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > Should be added to the list of flow related files. > > > > I did not add it because there is no way to split responsibility on a > > documentation section basis AFAIK, and only a fraction of this file contains > > information about rte_flow-related stuff. > > > > -- > > Adrien Mazarguil > > 6WIND > > There are already several maintainers for testpmd, adding another maintainer > for the flow parts of this file should be ok (I think).
True, however providing an exact file name instead of a directory or wildcard makes me the main maintainer/contact for that specific file (e.g. "app/test-pmd/cmdline_flow.c" vs. "app/test-pmd"), basically I do not want to be responsible for the entirety of testpmd's documentation. How about the following instead: another patch that extracts the flow command documentation in its own file (testpmd_flow.rst?) using the include directive (somewhat like cmdline_flow.c). This patch will update MAINTAINERS accordingly. -- Adrien Mazarguil 6WIND