Hi Vipin,
Thanks for the patch, I have a suggestion below.
On 5/17/2018 1:49 PM, Vipin Varghese wrote:
rte_event_eth_rx_adapter_create allocates eth_devices for currently
available eth devices. For dynamically created eth devices a new instance
for rx adapter has to be created.
Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index 834eb53..0ef18ce 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -63,7 +63,10 @@
* rte_event_eth_rx_adapter_service_id_get() function can be used to retrieve
* the service function ID of the adapter in this case.
*
- * Note: Interrupt driven receive queues are currently unimplemented.
+ * Note:
+ * 1) Interrupt driven receive queues are currently unimplemented.
+ * 2) rte_event_eth_rx_adapter_create() is not accounted for dynamic
+ * eth devices.
*/
Reword:
2) Devices created after calling rte_event_eth_rx_adapter_create()
should be added to a new instance of the rx adapter.
#ifdef __cplusplus
With the change above
Acked-by: Nikhil Rao <nikhil....@intel.com>
