30/05/2018 11:42, Ferruh Yigit: > On 5/30/2018 7:44 AM, Andrew Rybchenko wrote: > > Thomas, Ferruh, > > > > I've found out that the following patch is deferred in patchwork: > > https://dpdk.org/dev/patchwork/patch/40455/ > > > > It is critical under certain conditions since fix application crash. > > The patch is net/sfc local and just few lines - absolutely harmless. > > The only potential DPDK-wide effect is build, but the patch is really > > trivial and it is hard to imagine how it could affect the build. > > I'd like it to be included in 18.05, if possible. > > > > I understand that 18.05 is really very-very late already and it > > could be too late even for such patch. Just would like to > > double-check it. > > Hi Andrew, > > I did mark it as deferred and I overlooked that this fixes a crash. > > Agree that scope is local and only effect should be build, I confirmed the > build > but to be sure I suggest get the patch and trigger an Intel daily build, and > include the patch into release if only that build also returns success. > > > > > Thanks, > > Andrew. > > > > On 05/28/2018 09:50 AM, Andrew Rybchenko wrote: > >> Rx descriptor status callback was lost and request of the Rx > >> descriptor status crashes application if equal stride super-buffer > >> Rx mode is used. > >> > >> Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") > >> > >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
Applied, thanks for the heads up.