>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:[email protected]]
>Sent: 20 June 2018 12:56
>To: Verma, Shally <[email protected]>
>Cc: Trahe, Fiona <[email protected]>; [email protected]; Athreya, Narayana
>Prasad <[email protected]>;
>Challa, Mahipal <[email protected]>; Gupta, Ashish
><[email protected]>; Sahu, Sunila
><[email protected]>
>Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support
>
>External Email
>
>Hi Shally,
>
>> -----Original Message-----
>> From: Verma, Shally [mailto:[email protected]]
>> Sent: Wednesday, June 20, 2018 7:02 AM
>> To: De Lara Guarch, Pablo <[email protected]>
>> Cc: Trahe, Fiona <[email protected]>; [email protected]; Athreya, Narayana
>> Prasad <[email protected]>; Challa, Mahipal
>> <[email protected]>; Gupta, Ashish <[email protected]>;
>> Sahu, Sunila <[email protected]>
>> Subject: RE: [PATCH v1 7/7] drivers/compress: add meson.build support
>>
>>
>>
// snip
>> >> Also change the config and drv format flags to append _compress to
>> >> use compression specific format for global filenames. This also
>> >> require change in compression PMDs to rename their version.map files
>> >> as rte_pmd_<pmd
>> >> name>_compress.map ex. Isal should rename as
>> >> rte_pmd_isal_compress_version.map.
>> >>
>> >> Currently the drivers/compress/meson.build use the generic config
>> >> names with no compress specific specifier. This breaks meson build
>> >> when vendor uses same name for different PMDs, where all belongs to same
>> platform.
>> >> Ex. drivers/net/octeontx, drivers/event/octeontx,
>> >> drivers/compress/octeontx where, net, event and compress carry PMD
>> >> for eth, event and compression devices for Octeontx platform. Thus,
>> >> differentiate globally used files using module specific specifier ex.
>> >> rte_pmd_octeontx_compress_version.map
>> >> and rte_pmd_octeontx_event_version.map
>> >
>> >I think instead of forcing all the PMDs to use that suffix, if there
>> >are drivers with the same PMD, they can add the "compres" suffix, without
>> imposing it to others.
>> >
>> [Shally] Meson build force us to use then directory name as octeontx_compress
>> where as we want to keep it as compress/octeontx (on the similar lines of
>> net/octeontx, event/octeontx). Also its already under compress, so having it
>> as
>> compress/octeontx_compress looks unnecessary,
>
>For null crypto, the directory is called crypto/null and it is built with
>meson (and there is also a net/null).
>Maybe doing something like that will work?
>
>If it doesn't, then you can add this, but make sure that you fix
>the isal export map name in the Makefile too.
>
[Shally] fine. I will check for this and if required, will send patch for ISAL
as well.
>Thanks,
>Pablo
>
>>
>> Thanks
>> Shally
