Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

[Andy Green]

On 08/01/2018 06:47 PM, Kevin Traynor wrote:
On 05/28/2018 04:31 AM, Andy Green wrote:
Hi -

Between 18.02 and the putative 18.05 there were changes in the way the
meter stuff deals with its config.

I updated the related code in lagopus, but I get warnings about using
the new APIs (it's the same for rte_meter_trtcm_profile_config())

./dpdk/meter.c: In function 'dpdk_register_meter':
./dpdk/meter.c:119:7: warning: 'rte_meter_srtcm_profile_config' is
deprecated: Symbol is not yet part of stable ABI
[-Wdeprecated-declarations]
        rte_meter_srtcm_profile_config(&lband->sp, &param);
        ^
In file included from ./dpdk/meter.c:27:0:
/home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note:
declared here
  rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,
  ^
./dpdk/meter.c:132:7: warning: 'rte_meter_srtcm_profile_config' is
deprecated: Symbol is not yet part of stable ABI
[-Wdeprecated-declarations]
        rte_meter_srtcm_profile_config(&lband->sp, &param);
        ^
In file included from ./dpdk/meter.c:27:0:
/home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note:
declared here
  rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p,


Hi Cristian,

Are these API still to be considered experimental in 18.08, or the tags
can be removed?

... to be clear that these apis claimed to be 'experimental' in 18.05 at 
all, when they aren't, is already broken in 18.05.

The only question is whether they want to continue ignoring the breakage 
into 18.08+ so future generations can enjoy it.

-Andy

Kevin.


As far as I can see this api change is not optional, it changes the
parameters for related apis to require a struct prepared with these new
apis.

-Andy