03/08/2018 15:45, Pattan, Reshma: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 1, 2018 8:52 AM > > > > 01/08/2018 00:18, Reshma Pattan: > > > v10: fixed clang compiler issues and freed latency stats memzone in > > > latency stats unit tests. > > > v9: rebased ontop of latest autotest changes and added new tests to > > > the autotest list > > > v8: renamed commit headline and freed the metrics memzone for bitrate > > > ut > > > v7: removed unused macros and corrected the comment > > > v6: updated ring variable appropriately > > > v5: rebased, freed pools and rings, created common patch set > > > --- > > > > Sorry, the integration of this patchset is very painful. > > > > After asking for rebase, for clang fix, there are still some basic errors > > with 32- > > bit compilation: > > > > test_latencystats.c:131:21: error: > > format ‘%ld’ expects argument of type ‘long int’, > > but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’} > > > > linkage: > > > > test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined > > reference to `test_pdump' > > > > or even MAINTAINERS file: > > > > test/test/sample_packet_forward.c > > test/test/sample_packet_forward.h > > test/test/test_bitratestats.c > > test/test/test_latencystats.c > > > > I have already spent too much time on it, despite it is not fixing 18.08. > > > > Please do a complete detailed review of this series, so it can be > > considered for > > 18.11. > > > > We missed to do these basic checks, apologies for consuming your time. > Naga Suresh has now proactively worked on fixing these issues and running > pre checks on patches and addressed in v12. > The earlier versions were reviewed by me, Remy and Anatoly . So we request > you to consider latest patches for 18.08, > until unless they don’t give any last minute surprises.
Sorry, I consider it is now too late for such patch in 18.08. It is not fixing any issue. Last days of 18.08 cycle will be really focus on bugs and doc.