02/08/2018 16:43, Harry van Haaren:
> This commit fixes a bug in a 32-bit environment where the
> generic ring_init() would fail, but given the interaction
> with memzones the next iteration of the event_ring_autotest
> would actually *pass* because the ring in question would
> exist already an be looked-up.
>
> This commit rightly error checks the result of ring_init(),
> and calls rte_free() on the memory as required.
>
> Fixes: dc39e2f359b5 ("eventdev: add ring structure for events")
> Cc: bruce.richard...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
> Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com>
>
> ---
>
> v2:
> - Removed _ from headline for check git log (Jerin)
This is not the spirit of this check.
You are expected to not use function names at all,
in order to provide a title readable by someone who does not know
the function or structure names of this area.
In this case, it can be:
event: fix ring init failure handling
> - Added memzone free (good catch, thanks Jerin)
> - Return NULL instead of 0 (Jerin)
> - Added Jerin's Ack
>
> Cc: tho...@monjalon.net
> Cc: jerin.ja...@caviumnetworks.com
>
> Please consider this for RC3, as it fixes the unit tests
> on 32-bit systems.
Applied, thanks
