> -----Original Message----- > From: Dumitrescu, Cristian > Sent: Monday, September 24, 2018 6:12 PM > To: Vivek Sharma <vivek.sha...@caviumnetworks.com> > Cc: Sharma, Vivek <vivek.sha...@cavium.com>; sta...@dpdk.org; > dev@dpdk.org > Subject: RE: [PATCH v1] eal: use correct data type for slab operations > > > > > -----Original Message----- > > From: Vivek Sharma [mailto:vivek.sha...@caviumnetworks.com] > > Sent: Monday, September 24, 2018 4:50 PM > > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com> > > Cc: Sharma, Vivek <vivek.sha...@cavium.com>; sta...@dpdk.org; > > dev@dpdk.org > > Subject: Re: [PATCH v1] eal: use correct data type for slab operations > > > > + dev. > > +cristian(Bitmap maintainer) > > > > Please review. > > > > Thanks! > > > > On Monday 24 September 2018 09:08 PM, Vivek Sharma wrote: > > > Currently, slab operations use unsigned long data type for 64-bit slab > > > related operations. On target 'i686-native-linuxapp-gcc', unsigned long > > > is 32-bit and thus, slab operations breaks on this target. Changing slab > > > operations to use unsigned long long for correct functioning on all > targets. > > > > > > Fixes: de3cfa2c9823 ("sched: initial import") > > > Fixes: 693f715da45c ("remove extra parentheses in return statement") > > > CC: sta...@dpdk.org > > > > > > Signed-off-by: Vivek Sharma <vivek.sha...@caviumnetworks.com> > > > --- > > > lib/librte_eal/common/include/rte_bitmap.h | 14 +++++++------- > > > test/test/test_bitmap.c | 18 ++++++++++++++++++ > > > 2 files changed, 25 insertions(+), 7 deletions(-) > > > > > Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
Applied to next-qos tree, thanks!
