2015-04-09 12:40, Ravi Kerur: > Changes in v5 > Rebase to latest code. > > Changes in v4 > Make rte_eal_hugepage_init and rte_eal_hugepage_attach as > wrapper functions for BSD. > > Changes in v3 > Changed subject to be more explicit on file name inclusion. > > Changes in v2 > Use common function names rte_eal_hugepage_init and > rte_eal_hugepage_attach for BSD and Linux. Update comments about its > actuality in function declaration. > > Changes in v1 > Move common functions in eal_memory.c to librte_eal/common/ > eal_common_memory.c file. > > Following functions are moved to eal_common_memory.c file > > static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); > > Fix checkpatch warnings and errors. > > Signed-off-by: Ravi Kerur <rkerur at gmail.com> [...] > +/** > + * This function prepares physical memory mapping > + * i.e. hugepages on Linux and > + * contigmem on BSD.
OK > + * It is a wrapper function for BSD which will > + * internally call contigmem_init. Please avoid such comment which is difficult to maintain and not really useful. > + * It is a wrapper function for BSD which will > + * internally call contigmem_attach. Same comment. Except the above comments, it seems goods. Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com> Thanks
