On 10/10/2018 2:35 PM, Igor Russkikh wrote: > Hi Ferruh, > >>> +int rte_pmd_atl_dev_led_control(int port, int control); >> >> What is the intention here, making PMD specific public API? >> If so .map file is missing but we discourage using PMD specific APIs, >> >> can't it be possible to extend exiting led related dev_ops in a generic way >> to >> cover your use case? > > This API was specially requested by our customer. > > I'm honestly not sure if such a functionality will be useful as a generic > dev_ops. > I'm not aware of any other NIC allowing detailed led control. > > Maybe its better to drop this API from the patchset for now and resubmit > later on as a separate feature patchset. > > Is this ok with you?
+1, I think better to have it as separate patch.
