Already done by Ferruh. See attachment. Thanks Moti H.
> -----Original Message----- > From: John Daley (johndale) [mailto:[email protected]] > Sent: Wednesday, October 10, 2018 9:56 PM > To: Mordechay Haimovsky <[email protected]>; Adrien Mazarguil > <[email protected]>; Shahaf Shuler <[email protected]>; > Ori Kam <[email protected]>; [email protected] > Cc: [email protected] > Subject: RE: [PATCH] app/testpmd: fix flow query failure > > Ok, makes sense now, both flow query and flow list work with this patch, > yeah. > > Tested-by: John Daley <[email protected]> > > Remember that > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat > ches.dpdk.org%2Fpatch%2F46221%2F&data=02%7C01%7Cmotih%40me > llanox.com%7C554abadea7134471dc7e08d62ee21143%7Ca652971c7d2e4d9b > a6a4d149256f461b%7C0%7C0%7C636747945816028762&sdata=7eVxVq0 > AoN0hRVR%2Bb3bQvub5Q%2BXge6Cw9UqripZIWyk%3D&reserved=0 > still needs to be reverted out of dpdk-next-net/master otherwise we are still > broken. The patch was squished into e5b652ea34. > > -johnd > > > -----Original Message----- > > From: dev <[email protected]> On Behalf Of Mordechay Haimovsky > > Sent: Wednesday, October 10, 2018 10:05 AM > > To: Adrien Mazarguil <[email protected]>; Shahaf Shuler > > <[email protected]>; Ori Kam <[email protected]> > > Cc: [email protected]; Mordechay Haimovsky <[email protected]> > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure > > > > This patch fixes a bug found in port_flow_query routine which caused > > flow query command to fail with the following error "Caught error type > > 1 (cause > > unspecified): unknown object type to retrieve the name > > of: Invalid argument". > > > > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion > > function") > > > > Signed-off-by: Moti Haimovsky <[email protected]> > > --- > > app/test-pmd/config.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 009c92c..b11317b 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -1239,7 +1239,8 @@ void print_valid_ports(void) > > return -ENOENT; > > } > > ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR, > > - &name, sizeof(name), action, &error); > > + &name, sizeof(name), > > + (void *)(uintptr_t)action->type, &error); > > if (ret < 0) > > return port_flow_complain(&error); > > switch (action->type) { > > -- > > 1.8.3.1
