08/10/2018 23:45, Stephen Hemminger: > On Sun, 7 Oct 2018 11:32:39 +0200 > Thomas Monjalon <tho...@monjalon.net> wrote: > > > This is a follow-up of an idea presented at Dublin > > during the "hotplug talk". > > > > Instead of changing the existing hotplug functions, as in the RFC, > > some new experimental functions are added. > > The old functions lose their experimental status in order to provide > > a non-experimental replacement for deprecated attach/detach functions. > > > > It has been discussed briefly in the latest technical board meeting. > > > > > > Changes in v6 - after Gaetan's review: > > - bump ABI version of all buses (because of rte_device change) > > - unroll snprintf loop in rte_eal_hotplug_add > > > > Changes in v5: > > - rte_devargs_remove is fixed in case of null devargs (patch 2) > > - a pointer to the bus is added in rte_device (patch 3) > > - rte_dev_remove is fixed in case of no devargs (patch 5) > > > > Changes in v4 - after Andrew's review: > > - add API changes in release notes (patches 1 & 2) > > - fix memory leak in rte_eal_hotplug_add (patch 4) > > > > Change in v3: > > - fix null dereferencing in error path (patch 2) > > > > > > Thomas Monjalon (5): > > devargs: remove deprecated functions > > devargs: simplify parameters of removal function > > eal: add bus pointer in device structure > > eal: remove experimental flag of hotplug functions > > eal: simplify parameters of hotplug functions > > I like these changes. > > Reviewed-by: Stephen Hemminger <step...@networkplumber.org>
Applied