Re: [dpdk-dev] [PATCH v5 2/8] examples/cryptodev_fips_validate: add aes parser and enablement for test types

[Akhil Goyal]

On 10/17/2018 6:19 PM, Marko Kovacevic wrote:
> diff --git a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h 
> b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
> index beb6bed..5ac858d 100644
> --- a/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
> +++ b/examples/cryptodev_fips_validate/cryptodev_fips_validate.h
> @@ -23,6 +23,7 @@
>   #define FAX_FILE_PERFIX             "fax"
>   
>   enum fips_test_algorithms {
> +             FIPS_TEST_ALGO_AES = 0,
>               FIPS_TEST_ALGO_MAX
>   };
>   
> @@ -77,6 +78,21 @@ struct fips_test_callback {
>       struct fips_val *val;
>   };
>   
> +enum fips_aesavs_test_types {
> +     AESAVS_TYPE_GFXBOX = 0,
> +     AESAVS_TYPE_KEYSBOX,
> +     AESAVS_TYPE_VARKEY,
> +     AESAVS_TYPE_VARTXT,
> +     AESAVS_TYPE_MMT,
> +     AESAVS_TYPE_MCT,
> +};
It would be better to start the enums from 1. Consider a case when an 
uninitialized/unsupported type is accidentally used and it would be 
treated as AES and would be processed accordingly.