Hi Thomas and Jerin, The patches were extensively and heavily reviewed by Arm internally. As the 1st patch was not concluded, so I create a new series(2 patches),
> -----Original Message----- > From: Jerin Jacob <jerin.ja...@caviumnetworks.com> > Sent: Saturday, October 27, 2018 11:34 PM > To: Thomas Monjalon <tho...@monjalon.net> > Cc: Gavin Hu (Arm Technology China) <gavin...@arm.com>; dev@dpdk.org; > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; sta...@dpdk.org; > Ola Liljedahl <ola.liljed...@arm.com>; olivier.m...@6wind.com; > chao...@linux.vnet.ibm.com; bruce.richard...@intel.com; > konstantin.anan...@intel.com > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of > the tail > > -----Original Message----- > > Date: Sat, 27 Oct 2018 17:13:10 +0200 > > From: Thomas Monjalon <tho...@monjalon.net> > > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Cc: "Gavin Hu (Arm Technology China)" <gavin...@arm.com>, > "dev@dpdk.org" > > <dev@dpdk.org>, Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>, > > "sta...@dpdk.org" <sta...@dpdk.org>, Ola Liljedahl > > <ola.liljed...@arm.com>, "olivier.m...@6wind.com" > > <olivier.m...@6wind.com>, "chao...@linux.vnet.ibm.com" > > <chao...@linux.vnet.ibm.com>, "bruce.richard...@intel.com" > > <bruce.richard...@intel.com>, "konstantin.anan...@intel.com" > > <konstantin.anan...@intel.com> > > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and > > store of the tail > > > > > > 27/10/2018 17:00, Jerin Jacob: > > > From: Thomas Monjalon <tho...@monjalon.net> > > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > > > Hi Jerin > > > > > > > > > > As the 1st one of the 3-patch set was not concluded, I submit this 2- > patch series to unblock the merge. > > > > > > > > The thread is totally messed up because: > > > > - there is no cover letter > > > > - some different series (testpmd, i40e and doc) are in the same > thread > > > > - v4 replies to a different series > > > > - this version should be a v5 but has no number > > > > - this version replies to the v3 > > > > - patchwork still shows v3 and "v5" > > > > - replies from Ola are not quoting previous discussion > > > > > > > > Because of all of this, it is really difficult to follow. > > > > This is probably the reason of the lack of review outside of Arm. > > > > > > > > One more issue: you must Cc the relevant maintainers. > > > > Here: > > > > - Olivier for rte_ring > > > > - Chao for IBM platform > > > > - Bruce and Konstantin for x86 > > > > > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > > > But please consider better formatting your discussions, it is > > > > really important in our contribution workflow. > > > > > > > > I don't know what to do. > > > > I suggest to wait for more feedbacks and integrate it in -rc2. > > > > > > This series has been acked and tested. Sure, if we are looking for > > > some more feedback we can push to -rc2 if not it a good candidate to > > > be selected for -rc1. > > > > It has been acked and tested only for Arm platforms. > > And Olivier, the ring maintainer, was not Cc. > > > > I feel it is not enough. > > Sure, More reviews is already better. But lets keep as -rc2 target. > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
