Hi Dekel, Thursday, October 25, 2018 11:08 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v6 0/6] add encap and decap actions to Direct > Verbs flow in MLX5 PMD > > This series adds support of encap and decap actions in DV format. > L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support using raw > data buffer. > It is using the generic encapsulation framework from [1]. > > [1] "ethdev: add generic L2/L3 tunnel encapsulation actions" > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail > s.dpdk.org%2Farchives%2Fdev%2F2018- > October%2F114654.html&data=02%7C01%7Cshahafs%40mellanox.com > %7C5c61dd00f0ea45acba0608d63ab5c0e6%7Ca652971c7d2e4d9ba6a4d14925 > 6f461b%7C0%7C0%7C636760949640981142&sdata=tdOJhJfndTAP6Uotk > MJrkgBsa7AXljXJRMPsivfveUo%3D&reserved=0
In general looks good, please see some comments to address. > > --- > v6: > * Adapt L2 tunnel to VXLAN and NVGRE > * Add encap/decap using raw data > v5: > * Move DV actions code under common DV flag. > v4: > * Update in glue functions. > v3: > * Apply additional code review comments. > v2: > * Rebase on tip. > * Apply code review comments. > > > Dekel Peled (6): > net/mlx5: add flow action functions to glue > net/mlx5: add VXLAN encap action to Direct Verbs > net/mlx5: add VXLAN decap action to Direct Verbs > net/mlx5: add NVGRE encap action to Direct Verbs > net/mlx5: add NVGRE decap action to Direct Verbs > net/mlx5: add raw data encap decap to Direct Verbs > > drivers/net/mlx5/Makefile | 2 +- > drivers/net/mlx5/meson.build | 2 +- > drivers/net/mlx5/mlx5_flow.h | 15 + > drivers/net/mlx5/mlx5_flow_dv.c | 671 > +++++++++++++++++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_glue.c | 38 +++ > drivers/net/mlx5/mlx5_glue.h | 10 + > 6 files changed, 731 insertions(+), 7 deletions(-) > > -- > 1.8.3.1