Hi Marko,

I can see a compilation issue in the app.

/home/akhil/netperf/dpdk_up/dpdk-next-crypto/examples/fips_validation/fips_validation.c:
 
In function 'get_file_line':
/home/akhil/netperf/dpdk_up/dpdk-next-crypto/examples/fips_validation/fips_validation.c:31:25:
 
error: comparison is always true due to limited range of data type 
[-Werror=type-limits]
   while ((c = fgetc(fp)) != EOF) {
                          ^~
/home/akhil/netperf/dpdk_up/dpdk-next-crypto/examples/fips_validation/fips_validation.c:39:8:
 
error: comparison is always false due to limited range of data type 
[-Werror=type-limits]
   if (c == EOF)
         ^~
cc1: all warnings being treated as errors
/home/akhil/netperf/dpdk_up/dpdk-next-crypto/mk/internal/rte.compile-pre.mk:114:
 
recipe for target 'fips_validation.o' failed


On 10/26/2018 4:37 PM, Marko Kovacevic wrote:
> From: "Kovacevic, Marko" <marko.kovace...@intel.com>
>
> This sample application is made for the purpose so that users of DPDK
> who wish to get FIPS certification for their platforms, this sample app 
> enables
> users to parse test vectors that is gotten from NIST and be able to get
> a generated response file which they can then verify and be sure their
> system will pass FIPS certification.
>
>
> Marko Kovacevic (8):
> v6:
>    - Added MAINTAINER file into different patch
>    - Udpated documentation
>    - Changed app name and file location
>    - Fixed memory leak in TDES
>    - Changed patch titles
>    - Made other changes from comments
> v5:
>    - Changed patch titles
>    - Added MAINTAINERS File
>    - Removed bus_pci Dependency
>    - Updated documentation
>    - Changed app name
> v4:
> - Added Limitation
> - Changed TDES BLOCK SIZE from 16 -> 8
>    as DES block size is 64bits (main.c)
> v3:
> - Fixed a no-testing bug
> - Fixed some code style issue
>
> v2:
> - Refactor the code.
> - Move the code from test to sample applcation
>
> Kovacevic, Marko (8):
>    examples/fips_validation: add cryptodev fips compliant application
>    examples/fips_validation: support AES parsing
>    examples/fips_validation: support HMAC parsing
>    examples/fips_validation: support TDES parsing
>    examples/fips_validation: support GCM parsing
>    examples/fips_validation: support CMAC parsing
>    examples/fips_validation: support CCM parsing
>    doc: add fips validation application guide
>
>   MAINTAINERS                                     |    4 +
>   doc/guides/rel_notes/release_18_11.rst          |    5 +
>   doc/guides/sample_app_ug/fips_validation.rst    |  132 +++
>   doc/guides/sample_app_ug/index.rst              |    1 +
>   examples/fips_validation/Makefile               |   75 ++
>   examples/fips_validation/fips_validation.c      |  593 +++++++++++
>   examples/fips_validation/fips_validation.h      |  233 +++++
>   examples/fips_validation/fips_validation_aes.c  |  188 ++++
>   examples/fips_validation/fips_validation_ccm.c  |  272 +++++
>   examples/fips_validation/fips_validation_cmac.c |  116 +++
>   examples/fips_validation/fips_validation_gcm.c  |  125 +++
>   examples/fips_validation/fips_validation_hmac.c |  105 ++
>   examples/fips_validation/fips_validation_tdes.c |  264 +++++
>   examples/fips_validation/main.c                 | 1221 
> +++++++++++++++++++++++
>   examples/fips_validation/meson.build            |   20 +
>   15 files changed, 3354 insertions(+)
>   create mode 100644 doc/guides/sample_app_ug/fips_validation.rst
>   create mode 100644 examples/fips_validation/Makefile
>   create mode 100644 examples/fips_validation/fips_validation.c
>   create mode 100644 examples/fips_validation/fips_validation.h
>   create mode 100644 examples/fips_validation/fips_validation_aes.c
>   create mode 100644 examples/fips_validation/fips_validation_ccm.c
>   create mode 100644 examples/fips_validation/fips_validation_cmac.c
>   create mode 100644 examples/fips_validation/fips_validation_gcm.c
>   create mode 100644 examples/fips_validation/fips_validation_hmac.c
>   create mode 100644 examples/fips_validation/fips_validation_tdes.c
>   create mode 100644 examples/fips_validation/main.c
>   create mode 100644 examples/fips_validation/meson.build
>

Reply via email to