On 09.11.2018 12:38, Ophir Munk wrote: > This reverts the patch that enables default RSS action by setting > key=NULL and key_len=0. > In current testpmd implementation a key pointer must exist if > key_len!=0. For example, the following flow rule will cause a > segmentation fault: > flow create 0 <pattern> actions rss queues 0 1 end key_len 40 / end
Maybe it's better to check that 'key_len' and 'key' passed both or none? BTW, is there any profit from the 'key_len' argument for testpmd? Can we just always use the size of the passed 'key' and drop the configurable from the user interface? Best regards, Ilya Maximets.
