22/08/2018 16:37, Rami Rosen: > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id, > static void eth_dev_event_callback(char *device_name, > enum rte_dev_event_type type, > void *param); > -static int eth_dev_event_callback_register(void); > -static int eth_dev_event_callback_unregister(void);
I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler"). However I agree that some forward declarations could be removed, ideally all. Generally speaking, a lot of cleanup could be done in this file.