Hi Lee, Apologies if the logic is already done for my query
snipped > + /* Set private xform checksum */ > + switch (xform->compress.chksum) { > + /* Raw deflate by default */ Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating compress/isal instance? > + case(RTE_COMP_CHECKSUM_NONE): > + priv_xform->compress.chksum = IGZIP_DEFLATE; > + break; > + case(RTE_COMP_CHECKSUM_CRC32): > + priv_xform->compress.chksum = IGZIP_GZIP_NO_HDR; > + break; > + case(RTE_COMP_CHECKSUM_ADLER32): > + priv_xform->compress.chksum = IGZIP_ZLIB_NO_HDR; > + break; > + case(RTE_COMP_CHECKSUM_CRC32_ADLER32): > + ISAL_PMD_LOG(ERR, "Combined CRC and ADLER > checksum not" > + " supported\n"); > + return -ENOTSUP; > + default: > + ISAL_PMD_LOG(ERR, "Checksum type not > supported\n"); > + return -ENOTSUP; Do we not fall back to RTE_COMP_CHECKSUM_NONE if the configuration is wrong and report warning? snipped