On 12/17/2018 7:37 AM, Wenzhuo Lu wrote: > Update the documents too. > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > Signed-off-by: Qiming Yang <qiming.y...@intel.com> > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com> > Signed-off-by: Jingjing Wu <jingjing...@intel.com> > --- > MAINTAINERS | 2 + > config/common_base | 7 + > doc/guides/nics/features/ice.ini | 11 + > doc/guides/nics/ice.rst | 80 ++++ > doc/guides/nics/index.rst | 1 + > doc/guides/rel_notes/release_19_02.rst | 5 + > drivers/net/Makefile | 1 + > drivers/net/ice/Makefile | 54 +++ > drivers/net/ice/base/meson.build | 27 ++ > drivers/net/ice/ice_ethdev.c | 636 > ++++++++++++++++++++++++++++++++ > drivers/net/ice/ice_ethdev.h | 305 +++++++++++++++ > drivers/net/ice/ice_logs.h | 45 +++ > drivers/net/ice/ice_rxtx.h | 117 ++++++
I guess intention is to put this file (ice_rxtx.h) into next patch (16/31), file seems not used in this patch. <...> > +RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd); > +RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map); > +RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic | vfio-pci"); Also needs to set "RTE_PMD_REGISTER_PARAM_STRING()" macro here. <...>