> -----Original Message----- > From: Dumitrescu, Cristian > Sent: Friday, January 4, 2019 12:29 PM > To: [email protected] > Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing > <[email protected]>; Iremonger, Bernard <[email protected]>; > [email protected] > Subject: [PATCH v2] app/testpmd: fix quit to stop all ports before close > > This patch proposes a slightly different test-pmd quit operation: stop all > devices > before starting to close any device. Basically, stop all moving parts before > beginning to remove them. The current test-pmd quit is stopping and closing > each device before moving to the next device. > > If all devices in the system are independent of each other, this difference is > usually not important. In case of Soft NIC devices, any such virtual device > typically depends on one or more physical devices being alive, as it accesses > their queues, so this difference becomes important. > > Without this straightforward fix, all the Soft NIC devices need to be manually > stopped before the quit command is issued, otherwise the quit command can > sometimes crash the test-pmd application. > > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > Cc: [email protected] > > Signed-off-by: Cristian Dumitrescu <[email protected]>
Acked-by: Bernard Iremonger <[email protected]>
