Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, August 5, 2015 2:35 PM > To: Iremonger, Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in > rte_eth_bond_create() > > 2015-08-05 13:19, Iremonger, Bernard: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2015-08-05 13:36, Bernard Iremonger: > > > > if the name parameter to rte_eth_bond_create() was NULL, there was > > > > a segmentation fault because eth_dev was also NULL. > > > > > > You also add error handling of mac_addrs alloc and release_port(). > > > It deserves to be said in this commit message. > > > > Will I send a v3 patch ? > > My comment was mostly to show which kind of information may be useful. > Sometimes I write it myself. You are welcome to write it in order I add it or > you can send a v3. > > Other note: the function names are avoided in commit titles as they are > redundant with the title prefix and not so easy to read. > The title could be > bonding: fix crash on initialization error or, to include other fixes, > bonding: fix device initialization error handling > > Thanks
I will send a v3. Regards, Bernard.
