> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, August 03, 2015 4:13 PM > To: Carew, Alan; De Lara Guarch, Pablo > Cc: dev at dpdk.org; Liu, Yong > Subject: Re: [dpdk-dev] [PATCH] rte_power: fix sample vm_power_mgr not > work with Haswell cpus > > Ping > > 2015-07-10 14:24, Thomas Monjalon: > > Alan, Pablo, any comment? > > By the way, we need a maintainer for rte_power. > > > > 2015-07-07 16:36, Yong Liu: > > > From: Marvin Liu <yong.liu at intel.com> > > > > > > Two socket Haswell cpus on cottonwoodPass have 72 cores totally. And > this > > > number oversize the default value of maximum core number 64. > > > > > > Total number of channels should also increased for match core number. > > > > > > Signed-off-by: Marvin Liu <yong.liu at intel.com> > > >
NACK. Allowing that change may end up in an undefined behaviour if user uses core 64 or more. Will send an alternative fix, with a warning instead of an error, so user still can use the app on a machine with more than 64 cores, as long as no cores over 63 are used. Thanks, Pablo
