On 1/22/2019 3:44 PM, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.0 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > build error: > .../build/build/kernel/linux/kni/ixgbe_ethtool.c:1746:4: > error: too few arguments to function ‘dev_open’ > dev_open(netdev); > ^~~~~~~~ > In file included from .../build/kernel/linux/kni/ixgbe_ethtool.c:18: > .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here > int dev_open(struct net_device *dev, struct netlink_ext_ack *extack); > ^~~~~~~~ > > .../build/build/kernel/linux/kni/igb_ethtool.c:1812:4: > error: too few arguments to function ‘dev_open’ > dev_open(netdev); > ^~~~~~~~ > In file included from .../build/build/kernel/linux/kni/igb_ethtool.c:15: > .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here > int dev_open(struct net_device *dev, struct netlink_ext_ack *extack); > ^~~~~~~~ > > dev_open() is changed in Linux kernel version 5.0 and now requires > a new parameter, 'struct netlink_ext_ack *extack'. > Fixed by defining dev_open as macro when kernel version >= 5.0 > > Signed-off-by: Ferruh Yigit <[email protected]>
Off the topic. This is the patch 50000 in patchwork! This is a big number. Thanks everyone contributed! https://patches.dpdk.org/patch/50000/ The historical numbers from DPDK patchwork: 50000 - Jan. 22, 2019 (253 days) [ 8 months, 8 days / 36 weeks and 1 day ] 40000 - May. 14, 2018 (217 days) 30000 - Oct. 9, 2017 (258 days) 20000 - Jan. 25, 2017 (372 days) 10000 - Jan. 20, 2016 (645 days) 00001 - April 16, 2014 This is the first time DPDK patch pace slowed down (slightly), I guess this is because of the holidays in the middle and small 19.02, but I think next milestone which includes 19.05 will clarify this.
