On Thu, Jan 24, 2019 at 07:59:00PM +0300, Ilya Maximets wrote:
Read barrier must be implied between reading descriptor flags
and descriptor id. Otherwise, in case of reordering, we could
read wrong descriptor id.
For the reference, similar barrier for split rings is the read
barrier between VIRTQUEUE_NUSED (reading the used->idx) and
the call to the virtio_xmit_cleanup().
Additionally removed double update of 'used_idx'. It's enough
to set it in the end of the loop.
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Cc: sta...@dpdk.org
I don't think cc stable is required as 892dc798fa9c is only in
v19.02-rc1 and newer.
regards,
Jens
