On 2015/08/08 7:06, Ravi Kerur wrote: > Hi Tetsuya, > > On Thu, Aug 6, 2015 at 7:25 PM, Tetsuya Mukawa <mukawa at igel.co.jp > <mailto:mukawa at igel.co.jp>> wrote: > > On 2015/08/07 3:04, Ravi Kerur wrote: > > diff --git a/drivers/net/enic/enic_ethdev.c > b/drivers/net/enic/enic_ethdev.c > > index 8280cea..472ef5a 100644 > > --- a/drivers/net/enic/enic_ethdev.c > > +++ b/drivers/net/enic/enic_ethdev.c > > @@ -36,8 +36,8 @@ > > #include <stdio.h> > > #include <stdint.h> > > > > -#include <rte_dev.h> > > #include <rte_pci.h> > > +#include <rte_dev.h> > > #include <rte_ethdev.h> > > #include <rte_string_fns.h> > > Hi Ravi, > > Do we need this fixing? > > > > > diff --git a/drivers/net/mpipe/mpipe_tilegx.c > b/drivers/net/mpipe/mpipe_tilegx.c > > index 743feef..6e3e304 100644 > > --- a/drivers/net/mpipe/mpipe_tilegx.c > > +++ b/drivers/net/mpipe/mpipe_tilegx.c > > @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname, > > if (!eth_dev) { > > RTE_LOG(ERR, PMD, "%s: Failed to allocate > device.\n", ifname); > > rte_free(priv); > > + return -ENOMEM; > > How about separating this fixing from the patch, and put it as an > one of > cleanup patch series? > > > rte_pmd_mpipe_devinit is the init func pointer called via > rte_eal_vdev_init. Since we were fixing rte_eal_vdev_init thought of > taking care of mpipe issue. If you think it's unrelated to this patch > I will send a separate one. >
Hi Ravi, To avoid segmentation fault like above has a point, even if rest of this patch won't be applied. So I guess it's nice to separate the patch. Thanks, Tetsuya