25/01/2019 00:05, Vipin Varghese:
> Patches has to be validated for meson devtool script for
> code and document changes. Updating documentation for meson
> build steps in checking Compilation category.
>
> Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com>
> Tested-by: Marko Kovacevic <marko.kovace...@intel.com>
> Acked-by: Marko Kovacevic <marko.kovace...@intel.com>
> ---
>
> V4:
> - spelling correction for Compilation - Thomas Monjalon
> - restored double space for new header - Thomas Monjalon
> - reword the meson compilation content - Vipin Varghese
> - Added 'tested' and 'acked' from - Marko Kovacevic
>
> V3:
> removed extra character - Vipin Varghese
>
> V2:
> updated the meson build options - Bruce Richardson
> ---
> doc/guides/contributing/patches.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/contributing/patches.rst
> b/doc/guides/contributing/patches.rst
> index a64bb0368..e9048bbc0 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -473,6 +473,14 @@ The recommended configurations and options to test
> compilation prior to submitti
> export DPDK_DEP_PCAP=y
> export DPDK_DEP_SSL=y
The lines above are about the "make system".
We need a transition to explain that the "meson system" is different.
> +Compilation of patches is to be tested with ``test-meson-builds.sh`` script
> +in ``devtools`` directory of the DPDK repo::
Would be more straight-forward to give the full path:
devtools/test-meson-builds.sh
No need to add "DPDK repo".
> +
> + devtools/test-meson-builds.sh
Do we really need to repeat the script name here?
> +
> +The script internally checks for dependencies and tool chain. Then builds
> with
tool chain -> toolchain
> +shared and static libraries for Linux and BSD targets.
Why "Linux and BSD" ? It is just testing for the running OS.
