> > > Applications need to at least match DPDK's -march option to build > > > successfully due to some static inline functions in the public headers. > > > > > > This might cause problems, especially in distributions, so add a note > > > in the pkg-config description. > > > > > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja > > > builds") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Luca Boccassi <bl...@debian.org> > > > --- > > > At the moment there are no adversely affected applications in Debian and > > > Ubuntu (collectd builds a separate shared object, and > > > OVS/virtio-forwareder > > > are stand-alone DPDK-specific binaries), but we thought that having an > > > explicit notice would be good. > > > > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(), > > > libraries: dpdk_libraries, > > > libraries_private: dpdk_drivers + dpdk_static_libraries + > > > ['-Wl,-Bdynamic'] + dpdk_extra_ldflags, > > > -description: 'The Data Plane Development Kit (DPDK)', > > > +description: '''The Data Plane Development Kit (DPDK). > > > +Note that CFLAGS might contain an -march flag higher than typical > > > baseline. > > > +This is required for a number of static inline functions in the public > > From Arm's perspective, this notice is really necessary for some extensions > > like LSE to work for performance. > > Reviewed-by: Gavin Hu <gavin...@arm.com> > > > No objection from me for more documentation. > > Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Applied, thanks