Hi Vladimir, Thanks for stepping up for the maintaining job.
I agree with you that they are two parts and we mixed hash table and hashing function from beginning. They are actually should be two libraries, but at this Stage it is not very necessary to change the situation yet I think. If you trust us, I will definitely consult with you for questions coming up about thash (also other hash functions like crc and jhash to the corresponding Authors). I will also get more familiar with the code as the maintainer. Thanks Yipeng >-----Original Message----- >From: Gobriel, Sameh >Sent: Thursday, February 7, 2019 1:33 PM >To: Thomas Monjalon <tho...@monjalon.net>; Medvedkin, Vladimir ><vladimir.medved...@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.w...@intel.com>; Richardson, Bruce ><bruce.richard...@intel.com>; De Lara Guarch, >Pablo <pablo.de.lara.gua...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com> >Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of >Toeplitz hash > >I agree with Thomas. It makes sense to separate out hash function from hash >table implementation. > >Sameh > >-----Original Message----- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: Thursday, February 7, 2019 1:25 PM >To: Medvedkin, Vladimir <vladimir.medved...@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.w...@intel.com>; Gobriel, Sameh ><sameh.gobr...@intel.com>; Richardson, Bruce ><bruce.richard...@intel.com>; De Lara Guarch, Pablo ><pablo.de.lara.gua...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com> >Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of >Toeplitz hash > >07/02/2019 20:28, Medvedkin, Vladimir: >> On 06/02/2019 10:38, Thomas Monjalon wrote: >> > 05/02/2019 14:57, Vladimir Medvedkin: >> >> --- a/MAINTAINERS >> >> +++ b/MAINTAINERS >> >> +M: Vladimir Medvedkin <vladimir.medved...@intel.com> >> >> +F: lib/librte_hash/rte_thash.h >> > I'm not sure about adding maintainership for one file. >> > You are the author of this file, so you should be consulted during >> > reviews if you don't catch them by yourself. >> > But I prefer seeing maintainers as taking charge and understanding >> > of a full library as a block. >> > >> > And unfortunately, it does not work with the script: >> > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You >> > would appear as maintainer for all hash files. >> >> It could be solved by adding header. >> >> In fact thash is not used by other parts of the hash library (instead >> it could be used by softnic for example). >> >> From my point of view, hash library consists of two parts, hash table >> itself and a number of hash functions. Hash functions, in turn, can be >> used for many other purposes, not just for a hash table. Maybe we >> should separate hash functions and hash table? And if you think it is >> a bad idea, so be it, 4 maintainers for hash is enough. > >I don't know. >It's opening the door for more split of maintainers areas. >I would like to get more opinions from other maintainers, please. >
