> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, February 13, 2019 11:50 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z <qi.z.zh...@intel.com>; Zhao1, Wei
> <wei.zh...@intel.com>
> Subject: [PATCH v2] net/ice: enable VLAN filter offloads support

I think this is a fix, since vlan filter is already be promised by 
ice_dev_info_get.

So add below fix line.
Fixes: 690175ee51bf ("net/ice: support getting device information")
> 
> There is need to check whether dev_conf.rxmode.offloads is set when start ice
> device, if one of the vlan related bits is set, for example
> DEV_RX_OFFLOAD_VLAN_FILTER and so on, sevice start process to enable this
> offloads request.

Some typo, reword to

  VLAN filter is required to be configured during dev_start according to 
dev_conf.rxmod.offloads
setting, so ice_vlan_offload_set is called to handle this.
> 
> Signed-off-by: Wei Zhao <wei.zh...@intel.com>

Acked-by: Qi Zhang <qi.z.zh...@intel.com>

Applied to dpdk-next-net-intel with above changes.

Thanks
Qi

Reply via email to