> -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, March 1, 2019 6:37 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; > Yang, Qiming <qiming.y...@intel.com> > Cc: Stillwell Jr, Paul M <paul.m.stillwell...@intel.com>; dev@dpdk.org; Allan, > Bruce W <bruce.w.al...@intel.com> > Subject: Re: [PATCH 27/37] net/ice/base: resolve static analysis reported > issues > > On 2/28/2019 5:56 AM, Qi Zhang wrote: > > Resolve static analysis reported issue in ice_get_itr_intrl_gran and > > ice_ptg_find_ptype. > > Same comment with previous patch, related to the commit log. > > Commit log says "static analysis reported issues" are solved, what are they > really? > If we know them we can know your intention and say something about the code > below, otherwise is there a way to figure out if something wrong below?
OK, I think we can add more explanation here. > > And "impact" part, "what is the impact of the change?" Will those issues > create > definite memory corruption? Or protection for possible issue. Knowing this > helps > maintainers and LTS maintainers to priorities the patch accordingly. > The ice driver is claimed as an experimental release in 19.02, only basic function is enabled and the quality is not guaranteed, We assume user already know this and expected to meet some issue, Also 19.02 is not LTS release, so maintainer no need to worry about fix back port. so from my view, the "impact" part is not necessary to be highlighted for this patch but a nice to have, am I right? > Also please use "fix" instead of "resolve", fix is kind of keyword we tend to > use, > and provide a fixes line for whatever fixed. OK, will add fix line for this. Thanks Qi > > > > > Signed-off-by: Bruce Allan <bruce.w.al...@intel.com> > > Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell...@intel.com> > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> >
