Applied to next-net-mlx, thanks. From: Rami Rosen <ramir...@gmail.com> Sent: Monday, February 25, 2019 8:26 AM To: Thomas Monjalon <tho...@monjalon.net> Cc: Shahaf Shuler <shah...@mellanox.com>; Yongseok Koh <ys...@mellanox.com>; dev <dev@dpdk.org>; Ophir Munk <ophi...@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
Checked on Fedora 28 Reviewed-by: Rami Rosen <ramirose at gmail.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgmail.com&data=02%7C01%7Cshahafs%40mellanox.com%7Ca6471d19ffc94a63e8f308d69aea31bf%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636866727983375321&sdata=JE%2BULD6LG98IBEf6D%2F3bW98LivPLm2QD7xlshkdQDdc%3D&reserved=0>> On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <tho...@monjalon.net<mailto:tho...@monjalon.net>> wrote: The call to strlcpy uses either libc, libbsd or internal rte_strlcpy. No need to call the DPDK flavor explictly. Signed-off-by: Thomas Monjalon <tho...@monjalon.net<mailto:tho...@monjalon.net>> --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index df71707ccb..bda909eaa5 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, } /* Build device name. */ if (!switch_info->representor) - rte_strlcpy(name, dpdk_dev->name, sizeof(name)); + strlcpy(name, dpdk_dev->name, sizeof(name)); else snprintf(name, sizeof(name), "%s_representor_%u", dpdk_dev->name, switch_info->port_name); -- 2.20.1 -- regards, Rami Rosen