Hi, > -----Original Message----- > From: Zhang, Qi Z <qi.z.zh...@intel.com> > Sent: Thursday, March 07, 2019 8:11 AM > To: David Harton (dharton) <dhar...@cisco.com>; dev@dpdk.org; Lu, Wenzhuo > <wenzhuo...@intel.com>; Ananyev, Konstantin <konstantin.anan...@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef > > Hi > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Harton > > Sent: Wednesday, March 6, 2019 11:24 PM > > To: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; Ananyev, > > Konstantin <konstantin.anan...@intel.com> > > Cc: David Harton <dhar...@cisco.com> > > Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > > ixgbvef > > > > ixgevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable these offloads at configuration time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton <dhar...@cisco.com> > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > > *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > DEV_RX_OFFLOAD_SCATTER; > > > > if (hw->mac.type == ixgbe_mac_82598EB) > > offloads |= DEV_RX_OFFLOAD_VLAN_STRIP; > > > > - if (ixgbe_is_vf(dev) == 0) > > Patchwork shows "build patch error" for ci/Performance-Testing. > Seems this is the only place ixgbe_is_vf is used, so it can also be > removed
Yes, I didn't notice that. Assuming people are good with the fundamental change I'll post a new patch with ixgbe_is_vf removed. Thanks, Dave > > > - offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > - > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > > * mode. > > -- > > 2.19.1
