Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts?
Thanks, Anoob > -----Original Message----- > From: Trahe, Fiona <[email protected]> > Sent: Monday, March 11, 2019 4:11 PM > To: Anoob Joseph <[email protected]>; Akhil Goyal > <[email protected]>; Doherty, Declan <[email protected]>; De > Lara Guarch, Pablo <[email protected]> > Cc: Ankur Dwivedi <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Narayana Prasad Raju Athreya > <[email protected]>; Suheil Chandran <[email protected]>; > [email protected] > Subject: RE: [PATCH v2] lib/cryptodev: fix driver name comparison > > > > > -----Original Message----- > > From: dev [mailto:[email protected]] On Behalf Of Anoob Joseph > > Sent: Monday, March 11, 2019 5:56 AM > > To: Akhil Goyal <[email protected]>; Doherty, Declan > > <[email protected]>; De Lara Guarch, Pablo > > <[email protected]> > > Cc: Anoob Joseph <[email protected]>; Ankur Dwivedi > > <[email protected]>; Jerin Jacob Kollanukkaran > > <[email protected]>; Narayana Prasad Raju Athreya > > <[email protected]>; Suheil Chandran <[email protected]>; > > [email protected] > > Subject: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name > > comparison > > > > The string compare to the length of driver name might give false > > positives when there are drivers with similar names (one being the > > subset of another). > > > > Following is such a naming which could result in false positive. > > 1. crypto_driver > > 2. crypto_driver1 > > > > When strncmp with len = strlen("crypto_driver") is done, it could give > > a false positive when compared against "crypto_driver1". For such > > cases, 'strlen + 1' is done, so that the NULL termination also would > > be considered for the comparison. > > > > Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for > > crypto devices") > > > > Signed-off-by: Ankur Dwivedi <[email protected]> > > Signed-off-by: Anoob Joseph <[email protected]> > Acked-by: Fiona Trahe <[email protected]>
