On Fri, Mar 22, 2019 at 09:49:03AM +0800, Ye Xiaolong wrote: > On 03/21, Stephen Hemminger wrote: > >On Thu, 21 Mar 2019 17:18:41 +0800 > >Xiaolong Ye <xiaolong...@intel.com> wrote: > > > >> + > >> +RTE_PMD_REGISTER_VDEV(eth_af_xdp, pmd_af_xdp_drv); > > > >The convention in other network drivers is to use net_XXX in the vdev name. > >In AF_XDP that would be: > > > >RTE_PMD_REGISTER_VDEV(net_af_xdp, pmd_af_xdp_drv); > > Got it. > > > > >About naming, I would just drop AF_ from the name everywhere, the driver > >is about running over XDP, and the "AF_" is just a prefix for address family. > > > >Why not: > > net/xdp > > Thanks for the advice, Actually this driver is more about AF_XDP rathan than > XDP, the foundational objects it uses such as umem, umem fill ring, umem > completion ring, tx ring, rx ring which are all AF_XDP specfic, so I would > rather keep the naming. > +1 for the naming. AF_XDP is something different from XDP itself, though the former does use the latter.
/Bruce
