Hi,
While Coverity was down recently we looked at some other static code analysis
tools available to open source communities.
One of these is a new interesting tool called LGTM:
https://lgtm.com/projects/g/DPDK/dpdk/overview/
I ran a crosscheck git-blame and identified the probable* authors of the
defects. Can the people on the TO: list have a look at the defects that appear
to come from their code and submit fixes as necessary. See the full list below
for names, files and line numbers. Some of these are pretty minor but some are
definitely defects.
* git-blame may not be accurate in this case because the code may have changed
since the defect was introduced. The GUI has more information on the commits
that introduced some of the defects but that information wasn't available
outside the GUI.
You can drill down into the files using this link:
https://lgtm.com/projects/g/DPDK/dpdk/latest/files/
The defects are shown below.
John
Author File
Line
====== ====
====
[email protected] drivers/net/bnxt/bnxt_hwrm.c
256
[email protected] drivers/net/bnxt/bnxt_ethdev.c
3308
[email protected] drivers/net/bnxt/bnxt_ethdev.c
3316
[email protected] drivers/net/nfp/nfpcore/nfp_target.h
547
[email protected] drivers/net/avp/avp_ethdev.c
272
[email protected] drivers/net/sfc/base/medford2_nic.c
21
[email protected]
lib/librte_eal/common/eal_common_fbarray.c 55
[email protected] usertools/cpu_layout.py
25
[email protected]
drivers/mempool/bucket/rte_mempool_bucket.c 546
[email protected] drivers/net/sfc/base/ef10_ev.c
908
[email protected] drivers/net/sfc/base/ef10_filter.c
432
[email protected] drivers/net/sfc/base/ef10_filter.c
622
[email protected] drivers/net/sfc/base/ef10_filter.c
815
[email protected] drivers/net/sfc/base/ef10_filter.c
1329
[email protected] drivers/net/sfc/base/ef10_impl.h
69
[email protected] drivers/net/sfc/base/ef10_mac.c
289
[email protected] drivers/net/sfc/base/ef10_mcdi.c
221
[email protected] drivers/net/sfc/base/ef10_nic.c
1971
[email protected] drivers/net/sfc/base/ef10_nic.c
2454
[email protected] drivers/net/sfc/base/ef10_nic.c
2461
[email protected] drivers/net/sfc/base/ef10_nvram.c
2421
[email protected] drivers/net/sfc/base/ef10_nvram.c
2422
[email protected] drivers/net/sfc/base/ef10_rx.c
997
[email protected] drivers/net/sfc/base/ef10_rx.c
999
[email protected] drivers/net/sfc/base/ef10_tx.c
230
[email protected] drivers/net/sfc/base/ef10_tx.c
232
[email protected] drivers/net/sfc/base/ef10_tx.c
703
[email protected] drivers/net/sfc/base/ef10_tx.c
710
[email protected] drivers/net/sfc/base/ef10_tx.c
749
[email protected] drivers/net/sfc/base/ef10_tx.c
751
[email protected] drivers/net/sfc/base/efx.h
2906
[email protected] drivers/net/sfc/base/efx_impl.h
17
[email protected] drivers/net/sfc/base/efx_sram.c
30
[email protected] drivers/net/sfc/base/efx_sram.c
151
[email protected] drivers/net/sfc/base/hunt_nic.c
153
[email protected] drivers/net/sfc/sfc.c
188
[email protected] drivers/net/sfc/sfc_ef10_essb_rx.c
139
[email protected] drivers/net/sfc/sfc_ef10_essb_rx.c
525
[email protected] drivers/event/sw/sw_evdev_xstats.c
253
[email protected]
drivers/net/virtio/virtio_user/vhost_kernel_tap.h 1
[email protected] lib/librte_acl/acl_run_sse.h
1
[email protected] drivers/net/ixgbe/base/ixgbe_phy.c
207
[email protected] drivers/net/ixgbe/base/ixgbe_phy.c
211
[email protected] usertools/dpdk-telemetry-client.py
75
[email protected] usertools/dpdk-telemetry-client.py
90
[email protected] usertools/dpdk-telemetry-client.py
29
[email protected] usertools/dpdk-telemetry-client.py
44
[email protected] usertools/dpdk-telemetry-client.py
102
[email protected]
lib/librte_telemetry/rte_telemetry_parser.c 453
[email protected]
lib/librte_telemetry/rte_telemetry_parser.c 518
[email protected] drivers/bus/pci/linux/pci_uio.c
396
[email protected] drivers/bus/pci/linux/pci_uio.c
557
[email protected] drivers/common/qat/qat_device.c
195
[email protected] drivers/crypto/caam_jr/caam_jr.c
2270
[email protected] drivers/crypto/caam_jr/caam_jr.c
2283
[email protected] drivers/net/failsafe/failsafe_private.h
124
[email protected] drivers/net/failsafe/failsafe_private.h
179
[email protected] usertools/dpdk-devbind.py
389
[email protected] usertools/dpdk-devbind.py
396
[email protected] usertools/dpdk-devbind.py
405
[email protected] usertools/dpdk-devbind.py
414
[email protected] usertools/dpdk-devbind.py
452
[email protected] usertools/dpdk-devbind.py
459
[email protected] usertools/dpdk-devbind.py
206
[email protected] drivers/event/sw/sw_evdev_selftest.c
388
[email protected] drivers/event/sw/sw_evdev_selftest.c
480
[email protected] drivers/event/sw/sw_evdev_selftest.c
549
[email protected] drivers/event/sw/sw_evdev_selftest.c
710
[email protected] drivers/event/sw/sw_evdev_selftest.c
798
[email protected] drivers/event/sw/sw_evdev_selftest.c
2029
[email protected] drivers/event/sw/sw_evdev_selftest.c
2128
[email protected] drivers/event/sw/sw_evdev_selftest.c
2178
[email protected] drivers/event/sw/sw_evdev_selftest.c
2288
[email protected] drivers/event/sw/sw_evdev_selftest.c
2375
[email protected] drivers/event/sw/sw_evdev_selftest.c
2419
[email protected] drivers/net/virtio/virtio_rxtx.c
1120
[email protected] drivers/bus/fslmc/qbman/qbman_portal.c
934
[email protected] drivers/bus/fslmc/qbman/qbman_portal.c
1000
[email protected] drivers/mempool/dpaa/dpaa_mempool.c
299
[email protected] drivers/bus/dpaa/base/qbman/qman.h
1
[email protected]
drivers/bus/fslmc/qbman/include/fsl_qbman_debug.h 1
[email protected] lib/librte_vhost/vhost_user.h
5
[email protected]
drivers/net/atlantic/hw_atl/hw_atl_utils.c 465
intel.com usertools/cpu_layout.py
61
intel.com usertools/cpu_layout.py
7
intel.com usertools/dpdk-devbind.py
10
intel.com usertools/dpdk-devbind.py
347
intel.com usertools/dpdk-devbind.py
423
intel.com usertools/dpdk-devbind.py
432
intel.com drivers/net/e1000/base/e1000_i210.c
93
intel.com drivers/net/e1000/igb_rxtx.c
2278
intel.com drivers/net/ixgbe/ixgbe_rxtx.c
4497
intel.com drivers/net/e1000/base/e1000_82575.c
3415
intel.com drivers/net/e1000/base/e1000_82575.c
3419
intel.com drivers/net/ixgbe/base/ixgbe_phy.c
2165
intel.com drivers/net/ixgbe/base/ixgbe_phy.c
2169
intel.com drivers/net/ixgbe/ixgbe_pf.c
227
intel.com drivers/net/ixgbe/ixgbe_pf.c
381
intel.com drivers/net/e1000/base/e1000_manage.c
160
intel.com lib/librte_sched/rte_sched.c
752
[email protected] drivers/net/bonding/rte_eth_bond_pmd.c
3314
[email protected] drivers/net/thunderx/nicvf_rxtx.c
448
[email protected] drivers/net/thunderx/nicvf_rxtx.c
537
[email protected] drivers/net/virtio/virtio_ring.h
169
[email protected] drivers/net/virtio/virtio_user/vhost.h
5
[email protected]
drivers/crypto/virtio/virtio_cryptodev.c 1253
[email protected]
drivers/crypto/virtio/virtio_cryptodev.c 1337
[email protected]
drivers/crypto/virtio/virtio_cryptodev.c 778
[email protected] drivers/net/i40e/i40e_rxtx.c
1806
[email protected] drivers/net/i40e/i40e_rxtx.c
2144
[email protected] drivers/net/enic/enic_flow.c
1389
[email protected] drivers/net/enic/enic_flow.c
1516
[email protected] drivers/net/enic/enic_flow.c
1517
[email protected] usertools/dpdk-devbind.py
157
[email protected] drivers/net/i40e/i40e_ethdev.c
8817
[email protected] drivers/net/i40e/i40e_fdir.c
2035
[email protected] drivers/net/ixgbe/ixgbe_fdir.c
1459
[email protected] lib/librte_acl/acl_gen.c
373
[email protected] lib/librte_acl/acl_run_avx2.h
79
[email protected] lib/librte_acl/acl_bld.c
1384
[email protected] lib/librte_acl/acl_bld.c
1394
[email protected] lib/librte_acl/rte_acl.c
215
[email protected] lib/librte_acl/rte_acl.c
274
[email protected] lib/librte_acl/rte_acl.c
304
[email protected] lib/librte_bpf/bpf_exec.c
145
[email protected] lib/librte_bpf/bpf_exec.c
179
[email protected] drivers/net/cxgbe/sge.c
1193
[email protected] drivers/net/cxgbe/sge.c
1204
[email protected] drivers/net/cxgbe/sge.c
1217
[email protected] drivers/net/cxgbe/sge.c
1219
[email protected] drivers/net/cxgbe/sge.c
1227
[email protected] drivers/net/cxgbe/sge.c
1229
[email protected] drivers/event/opdl/opdl_ring.c
256
[email protected] drivers/event/opdl/opdl_ring.c
260
[email protected] drivers/event/opdl/opdl_ring.c
263
[email protected] drivers/event/opdl/opdl_ring.c
277
[email protected] drivers/event/opdl/opdl_ring.c
281
[email protected] drivers/event/opdl/opdl_ring.c
284
[email protected] drivers/net/e1000/igb_regs.h
148
[email protected]
drivers/net/af_packet/rte_eth_af_packet.c 700
[email protected]
drivers/net/af_packet/rte_eth_af_packet.c 790
[email protected] drivers/net/bonding/rte_eth_bond_pmd.c
48
[email protected] drivers/net/failsafe/failsafe_ops.c
479
[email protected] drivers/net/sfc/base/ef10_ev.c
956
[email protected] usertools/dpdk-pmdinfo.py
225
[email protected] usertools/dpdk-pmdinfo.py
70
[email protected] usertools/dpdk-pmdinfo.py
112
[email protected] usertools/dpdk-pmdinfo.py
181
[email protected] drivers/bus/fslmc/qbman/qbman_portal.c
803
[email protected] drivers/bus/fslmc/qbman/qbman_portal.c
860
[email protected] drivers/net/bonding/rte_eth_bond_args.c
228
[email protected] lib/librte_efd/rte_efd.c
584
[email protected] lib/librte_hash/rte_cuckoo_hash.c
570
[email protected] drivers/net/ice/base/ice_controlq.c
818
[email protected] drivers/net/ice/base/ice_controlq.c
896
[email protected] drivers/net/ice/base/ice_controlq.c
906
[email protected] drivers/net/atlantic/atl_ethdev.c
593
[email protected] drivers/event/octeontx/timvf_evdev.c
98
[email protected] drivers/event/octeontx/timvf_evdev.c
176
[email protected] drivers/net/ixgbe/base/ixgbe_common.c
5043
[email protected] drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
101
[email protected] drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
102
[email protected] drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
103
[email protected] drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
104
[email protected] drivers/net/cxgbe/base/t4_hw.c
3797
[email protected] drivers/net/cxgbe/cxgbe_ethdev.c
624
[email protected] drivers/net/cxgbe/sge.c
1252
[email protected] drivers/net/cxgbe/sge.c
1299
[email protected] drivers/net/cxgbe/sge.c
1302
[email protected] drivers/net/qede/base/ecore_dev.c
2843
[email protected]
drivers/net/qede/base/ecore_init_fw_funcs.c 211
[email protected]
drivers/net/qede/base/ecore_init_fw_funcs.c 493
[email protected] drivers/net/qede/base/ecore_chain.h
190
[email protected] drivers/net/qede/base/ecore_dev.c
3070
[email protected] drivers/net/qede/base/ecore_dev.c
3089
[email protected] drivers/net/qede/base/ecore_int.c
893
[email protected] drivers/net/qede/base/ecore_int.c
1154
[email protected] drivers/net/qede/base/ecore_int.c
1994
[email protected] drivers/net/qede/base/ecore_int_api.h
66
[email protected]
drivers/net/qede/base/ecore_init_fw_funcs.c 972
[email protected] drivers/net/qede/base/ecore_sriov.c
125
[email protected] drivers/net/qede/base/ecore_hw.c
588
[email protected] drivers/net/ena/base/ena_com.c
377
[email protected] drivers/net/ena/ena_ethdev.c
2572
[email protected] drivers/net/ena/ena_ethdev.c
2584
[email protected] drivers/net/ena/ena_ethdev.c
2595
[email protected]
lib/librte_eal/common/arch/x86/rte_cycles.c 105
[email protected] drivers/net/cxgbe/cxgbe_filter.c
196
[email protected] drivers/net/cxgbe/cxgbe_filter.c
292
[email protected] drivers/net/cxgbe/cxgbe_filter.c
316
[email protected] drivers/net/cxgbe/cxgbe_main.c
387
[email protected] drivers/net/dpaa/dpaa_rxtx.c
307
[email protected] drivers/net/dpaa/dpaa_rxtx.c
323
[email protected] drivers/net/dpaa/dpaa_rxtx.c
339
[email protected]
drivers/crypto/scheduler/scheduler_pmd_ops.c 474
[email protected] drivers/net/bnxt/bnxt_hwrm.c
3359
[email protected] drivers/net/enic/base/vnic_dev.c
224
[email protected] drivers/net/tap/tap_log.h
1
[email protected]
lib/librte_eal/common/eal_common_hexdump.c 39
[email protected]
lib/librte_eal/common/eal_common_hexdump.c 41
[email protected]
lib/librte_eal/common/eal_common_hexdump.c 46
[email protected] drivers/net/netvsc/hn_rxtx.c
126
[email protected] drivers/net/netvsc/hn_nvs.h
1
[email protected] drivers/net/netvsc/hn_rndis.h
1
[email protected] drivers/net/netvsc/hn_var.h
1
[email protected] drivers/net/dpaa2/dpaa2_flow.c
1726
[email protected]
drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c 267
[email protected]
drivers/raw/ifpga_rawdev/base/opae_hw_api.h 41
[email protected]
drivers/raw/ifpga_rawdev/base/opae_hw_api.h 201
[email protected] lib/librte_member/rte_member_vbf.c
121
[email protected] drivers/net/vhost/rte_eth_vhost.c
363
