> -----Original Message----- > From: Pattan, Reshma <reshma.pat...@intel.com> > Sent: Monday, April 1, 2019 8:58 PM > To: Phil Yang (Arm Technology China) <phil.y...@arm.com>; dev@dpdk.org; > tho...@monjalon.net > Cc: Hunt, David <david.h...@intel.com>; Gavin Hu (Arm Technology China) > <gavin...@arm.com>; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; nd <n...@arm.com>; nd <n...@arm.com> > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each worker > thread > > > > > -----Original Message----- > > From: Phil Yang (Arm Technology China) [mailto:phil.y...@arm.com] > > Sent: Saturday, March 30, 2019 4:55 PM > > To: Pattan, Reshma <reshma.pat...@intel.com>; dev@dpdk.org; > > tho...@monjalon.net > > Cc: Hunt, David <david.h...@intel.com>; Gavin Hu (Arm Technology > > China) <gavin...@arm.com>; Honnappa Nagarahalli > > <honnappa.nagaraha...@arm.com>; nd <n...@arm.com>; nd <n...@arm.com> > > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each > > worker thread > > > > > -----Original Message----- > > > From: Pattan, Reshma <reshma.pat...@intel.com> > > > Sent: Saturday, March 30, 2019 12:40 AM > > > To: Phil Yang (Arm Technology China) <phil.y...@arm.com>; > > > dev@dpdk.org; tho...@monjalon.net > > > Cc: Hunt, David <david.h...@intel.com>; Gavin Hu (Arm Technology > > > China) <gavin...@arm.com>; Honnappa Nagarahalli > > > <honnappa.nagaraha...@arm.com>; nd <n...@arm.com> > > > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each > > > worker thread > > > > > > > > > > > > > -----Original Message----- > > > > From: Phil Yang [mailto:phil.y...@arm.com] > > > > > > > > The current implementation using '__sync' built-ins to synchronize > > > > statistics within worker threads. '__sync' built-ins functions are > > > > full barriers which will affect the performance, so add a per > > > > worker packets > > > statistics. > > > > > > > > Enable by option --insight-worker. > > > > > > > > > > I don't feel the need of this new option to print per core stats. > > > Any reason for this? > > > > Hi Reshma, > > > > Thanks for your comment. > > The per core stats aims at removing the '__sync' builtin full barrier > > in the worker thread. > > It records the workload of each core (It shows the bottleneck core as well). > > Since the maximum core number may be more than 128, so disable the > > print in default and add this new option for debugging use. > > > > Ok fine with me then. > > Thanks, > Reshma
Thanks for your review. Thanks, Phil
