On 4/1/2019 4:25 PM, Thomas Monjalon wrote:
29/03/2019 00:24, Anand Rawat:
Added meson workarounds to build helloworld on windows.
Windows currently only supports kvargs and eal libraries.
This change restricts the build flow to supported libraries
only.
[...]
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,5 +1,9 @@
  # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2017 Intel Corporation
+# Copyright(c) 2017-2019 Intel Corporation
+
+if host_machine.system() == 'windows'
+       subdir_done()
+endif

Not sure this change deserves a copyright update :)

I am not sure either, basic principle that I am following
is if any file is touched with some code/logic the license
should be updated. Do correct me if I am wrong. I can make
the changes accordingly in the future releases.


--- a/examples/meson.build
+++ b/examples/meson.build
-       deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']

Please keep this line intact.

+       if host_machine.system() != 'windows'
+               deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
+       else
+               deps = ['eal'] # only supported lib on windows currently
+       endif

You could override deps for Windows only.


Will be updated in v8

--
Anand Rawat

Reply via email to