Hi Pavan, > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Pavan Nikhilesh > Bhagavatula > Sent: Sunday, March 31, 2019 4:14 PM > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Thomas Monjalon > <tho...@monjalon.net>; arybche...@solarflare.com; > ferruh.yi...@intel.com; bernard.iremon...@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > <pbhagavat...@marvell.com> > Subject: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly > mode > > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > > Optimize testpmd txonly mode by > 1. Moving per packet ethernet header copy above the loop. > 2. Use bulk ops for allocating segments instead of having a inner loop for > every segment. > > Also, move the packet prepare logic into a separate function so that it can be > reused later. > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > --- > v5 Changes > - Remove unnecessary change to struct rte_port *txp (movement). > (Bernard) > > v4 Changes: > - Fix packet len calculation. > > v3 Changes: > - Split the patches for easier review. (Thomas) > - Remove unnecessary assignments to 0. (Bernard) > > v2 Changes: > - Use bulk ops for fetching segments. (Andrew Rybchenko) > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew Rybchenko) > - Fix mbufs not being freed when there is no more mbufs available for > segments. (Andrew Rybchenko) > > app/test-pmd/txonly.c | 139 +++++++++++++++++++++++------------------- > 1 file changed, 76 insertions(+), 63 deletions(-) >
The patch doesn't apply. It conflicts with 82010ef55 app/testpmd: make txonly mode generate multiple flows (http://patches.dpdk.org/patch/51869/). Can you please rebase? Thanks, Ali
