On 4/2/2019 3:51 PM, Thomas Monjalon wrote:
02/04/2019 05:54, Anand Rawat:
Added meson workarounds to build helloworld on Windows.
Windows currently only supports kvargs and eal libraries.
This change restricts the build flow to supported libraries
only.
Signed-off-by: Anand Rawat <anand.ra...@intel.com>
Signed-off-by: Pallavi Kadam <pallavi.ka...@intel.com>
Reviewed-by: Jeff Shaw <jeffrey.b.s...@intel.com>
Reviewed-by: Ranjit Menon <ranjit.me...@intel.com>
---
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -35,7 +35,9 @@ foreach example: examples
ext_deps = [execinfo]
includes = [include_directories(example)]
- deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
+ if host_machine.system() == 'windows'
+ deps = ['eal'] # only supported lib on Windows currently
+ endif
subdir(example)
This is not what I call keeping build intact for Linux/BSD :)
I did not catch it before because test-meson-builds.sh is not testing
compilation of the examples with meson. Bruce, may we add it?
I will add back the original deps line in master branch.
That is correct,
deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']
should have not been removed from this file. Please add the line
back.
--
Anand Rawat
