On Wed, Apr 3, 2019 at 6:53 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote:
> On 4/3/2019 5:41 PM, Bruce Richardson wrote: > > On Wed, Apr 03, 2019 at 05:35:22PM +0100, Ferruh Yigit wrote: > >> On 4/3/2019 5:27 PM, Thomas Monjalon wrote: > >>> 03/04/2019 18:07, Mohammad Abdul Awal: > >>>> Null value for parameter name will cause segfault for the strnlen and > >>>> strcmp functions. > >>> > >>> I'm not sure we want such obvious checks for all APIs. Here I would > >>> say yes. > >> > >> These are internal functions, not APIs. I am for verifying input for > >> (all) APIs but not for internal functions, drivers should call them and > >> they are in our control, if they are passing NULL we can fix them :) > >> > > True, but if these are control path or init time code paths rather than > > data path APIs, I don't see the harm in putting in the checks. > > No harm from performance point of view, agree, but also looks unnecessary > to me. > +1 All the more when you see the following patches that adds input checks in the faulty/too naive drivers. -- David Marchand
